Fix #2980: Crash when inlining HK type parameters #2984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we inline we need to construct new trees with new symbols. This is handled by TreeTypeMap which was missing a case for LambdaTypeTree (the parameters of a type lambda are TypeDefs and thus have symbols that need to be replaced). This caused a crash in pickling since we ended up trying to pickle the same symbol twice.
smarter
force-pushed
the
fix-inline-lambda
branch
from
43b5978 to
d73b383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we inline we need to construct new trees with new symbols. This is
handled by TreeTypeMap which was missing a case for LambdaTypeTree (the
parameters of a type lambda are TypeDefs and thus have symbols that need
to be replaced). This caused a crash in pickling since we ended up
trying to pickle the same symbol twice.